Cover test-build ordering, build-results, and test/install ON_ERROR_STOP - #79
Merged
jnasbyupgrade merged 1 commit intoSep 8, 2026
Conversation
…TOP [4916368] Template's test/install file now sets ON_ERROR_STOP and stops committing its self-overwriting .out file, per pgxntool's new check-test-install-error-stop check. Add test coverage for the new installcheck:test-build ordering edge, make build-results, and check-test-install-error-stop (script-level and Makefile-wiring). Covers pgxntool issues Postgres-Extensions/pgxntool#108 and Postgres-Extensions/pgxntool#97 (fixed by the paired pgxntool commit above, not by this one). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
2 tasks
jnasbyupgrade
added a commit
to jnasbyupgrade/pgxntool-test
that referenced
this pull request
Sep 8, 2026
…dry-run behavior, drop a second uninstall Document that install's dry-run visibility comes from having no on-disk file named "install" rather than a .PHONY declaration (checked pgxs.mk and base.mk -- neither marks it phony), per reviewer request to verify rather than assume. Merge the FS_INSTALL=no negative-case check into the existing issue Postgres-Extensions#79 uninstalled-tree test so both share a single uninstall instead of each test uninstalling separately. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related pgxntool PR: Postgres-Extensions/pgxntool#109
Template's
test/installfile now setsON_ERROR_STOPand stops committing its self-overwriting.outfile, per pgxntool's newcheck-test-install-error-stopcheck.Test coverage added:
installcheck:test-buildordering edge, viamake -ndry-run (issue #108)make build-results: refreshes clean files, skips and reports files whose actual output containsERROR:, and still exits non-zero on a partial skipcheck-test-install-error-stop: script-level decision logic (directON_ERROR_STOP, viapsql.sql, missing) and Makefile wiring (recipe args, disable viaPGXNTOOL_ENABLE_TEST_INSTALL_ERROR_STOP_CHECK, exit-status propagation)Covers pgxntool issues #108 and #97 (fixed by the paired pgxntool PR above, not by this one).